Replace moment.js with native Date/Intl APIs by lkostrowski · Pull Request #6404 · saleor/saleor-dashboard

lkostrowski · 2026-03-09T19:52:04Z

Scope of the change

Replace moment.js with native JavaScript Date and Intl APIs in 4 trivially replaceable cases. This reduces dependency on a deprecated library while maintaining equivalent functionality.

Changes:

TaxAppLabel: use Intl.DateTimeFormat with user locale for date display
useNewUserCheck: use native Date for validation and comparison
handlers (preorder): use native Date for past-date check
GiftCard utils: use native Date for expiry comparison
Add TaxAppLabel unit tests for date formatting
I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
I used analytics "trackEvent" for important events

Note: Other moment.js usages in the codebase remain unchanged (12+ files still depend on moment).

changeset-bot · 2026-03-09T19:52:08Z

🦋 Changeset detected

Latest commit: 75cbd58

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

This PR removes a few moment.js usages and replaces them with native Date/Intl APIs to reduce reliance on a deprecated dependency, plus adds a unit test around TaxAppLabel date formatting.

Changes:

Replace moment with native Date comparisons in useNewUserCheck, preorder handlers, and gift card expiry logic.
Update TaxAppLabel to format dates via Intl.DateTimeFormat using the user locale.
Add TaxAppLabel unit tests and a changeset entry.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/welcomePage/WelcomePageOnboarding/hooks/useNewUserCheck.ts	Swaps moment parsing/comparison for native `Date` parsing and `>` comparison.
src/taxes/components/TaxAppLabel.tsx	Replaces `moment(created).format(...)` with `Intl.DateTimeFormat(locale).format(...)`.
src/taxes/components/TaxAppLabel.test.tsx	Adds unit coverage for localized date rendering and conditional sections.
src/products/utils/handlers.ts	Replaces moment-based preorder end-date validation with native `Date` comparison.
src/giftCards/GiftCardUpdate/providers/GiftCardDetailsProvider/utils.ts	Replaces moment-based expiry check with native `Date` comparison.
.changeset/plenty-peaches-agree.md	Adds a changeset entry for the moment removal.

.changeset/plenty-peaches-agree.md

src/welcomePage/WelcomePageOnboarding/hooks/useNewUserCheck.ts

src/taxes/components/TaxAppLabel.tsx

src/giftCards/GiftCardUpdate/providers/GiftCardDetailsProvider/utils.ts

codecov · 2026-03-09T20:44:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.19%. Comparing base (142b8cf) to head (75cbd58).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/taxes/components/TaxAppLabel.stories.tsx	0.00%	6 Missing ⚠️
...ders/GiftCardListProvider/GiftCardListProvider.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             main    #6404     +/-   ##
=========================================
  Coverage   43.18%   43.19%             
=========================================
  Files        2526     2527      +1     
  Lines       44061    44074     +13     
  Branches    10400    10401      +1     
=========================================
+ Hits        19027    19037     +10     
+ Misses      24993    23715   -1278     
- Partials       41     1322   +1281

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/giftCards/GiftCardUpdate/providers/GiftCardDetailsProvider/utils.ts

src/taxes/components/TaxAppLabel.tsx

- TaxAppLabel: use Intl.DateTimeFormat with user locale for date display - useNewUserCheck: use native Date for validation and comparison - handlers (preorder): use native Date for past-date check - GiftCard utils: use native Date for expiry comparison - Add TaxAppLabel unit tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Copilot · 2026-03-11T10:36:38Z

src/taxes/components/TaxAppLabel.tsx

+  const dateTimeString = new Intl.DateTimeFormat(locale, {
+    year: "numeric",
+    month: "2-digit",
+    day: "2-digit",
+  }).format(new Date(created));


new Date(created) passed into Intl.DateTimeFormat(...).format(...) will throw a RangeError: Invalid time value if created is not a valid date string, which would crash the label render. Consider validating the parsed Date (e.g., isNaN(date.getTime())) and either skipping rendering or falling back to a safe placeholder when invalid.

Suggested change

const dateTimeString = new Intl.DateTimeFormat(locale, {

year: "numeric",

month: "2-digit",

day: "2-digit",

}).format(new Date(created));

const date = new Date(created);

if (isNaN(date.getTime())) {

return "";

}

const dateTimeString = new Intl.DateTimeFormat(locale, {

year: "numeric",

month: "2-digit",

day: "2-digit",

}).format(date);

Copilot · 2026-03-11T10:36:38Z

src/welcomePage/WelcomePageOnboarding/hooks/useNewUserCheck.ts

+  // Reset time, so timezone will not flip the day
+  const thresholdDate = new Date(`${thresholdDateString}T00:00:00`);


thresholdDateString is treated as a plain date and you append T00:00:00 unconditionally. If the env var is ever set to an ISO datetime (contains T/timezone), this will produce an invalid date and make all users evaluate as not new. Consider parsing the env value as-is when it already includes a time component, and only appending T00:00:00 for date-only values.

Suggested change

// Reset time, so timezone will not flip the day

const thresholdDate = new Date(`${thresholdDateString}T00:00:00`);

// Reset time, so timezone will not flip the day for date-only values.

// If the env var already includes a time component (e.g. full ISO datetime),

// parse it as-is to avoid creating an invalid date string.

const thresholdDate = thresholdDateString.includes("T")

? new Date(thresholdDateString)

: new Date(`${thresholdDateString}T00:00:00`);

src/giftCards/GiftCardUpdate/providers/GiftCardDetailsProvider/utils.ts

src/giftCards/GiftCardsList/providers/GiftCardListProvider/GiftCardListProvider.tsx

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-11T14:13:27Z

src/giftCards/GiftCardUpdate/providers/GiftCardDetailsProvider/utils.ts

+export function getExtendedGiftCard<T extends GiftCardBase>(
+  giftCard?: T,
+): ExtendedGiftCard<T> | undefined {
+  // todo do not accept optional value, check for existence higher


The inline note // todo ... should be normalized to the repo’s TODO: convention (and ideally include a tracking reference) so it can be found by tooling and won’t get forgotten.

Suggested change

// todo do not accept optional value, check for existence higher

// TODO: do not accept optional value; check for existence higher

lkostrowski requested a review from a team as a code owner March 9, 2026 19:52

lkostrowski requested review from Copilot and witoszekdev March 9, 2026 19:52

Copilot started reviewing on behalf of lkostrowski March 9, 2026 19:52 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

witoszekdev previously approved these changes Mar 10, 2026

View reviewed changes

src/giftCards/GiftCardUpdate/providers/GiftCardDetailsProvider/utils.ts Outdated Show resolved Hide resolved

src/taxes/components/TaxAppLabel.tsx Outdated Show resolved Hide resolved

lkostrowski dismissed witoszekdev’s stale review via d16a500 March 11, 2026 07:08

lkostrowski requested a review from witoszekdev March 11, 2026 07:09

lkostrowski enabled auto-merge (squash) March 11, 2026 07:10

witoszekdev previously approved these changes Mar 11, 2026

View reviewed changes

lkostrowski and others added 4 commits March 11, 2026 11:28

CR fixes

30352ca

story for app label

554d23a

fix types

c6d484a

Copilot AI review requested due to automatic review settings March 11, 2026 10:29

lkostrowski dismissed witoszekdev’s stale review via c6d484a March 11, 2026 10:29

lkostrowski force-pushed the lkostrowski/replace-moment-native branch from d16a500 to c6d484a Compare March 11, 2026 10:29

Copilot started reviewing on behalf of lkostrowski March 11, 2026 10:29 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

lkostrowski requested a review from witoszekdev March 11, 2026 13:43

Merge branch 'main' into lkostrowski/replace-moment-native

0018527

witoszekdev approved these changes Mar 11, 2026

View reviewed changes

Merge branch 'main' into lkostrowski/replace-moment-native

75cbd58

Copilot AI review requested due to automatic review settings March 11, 2026 13:59

lkostrowski merged commit 659142b into main Mar 11, 2026
19 checks passed

lkostrowski deleted the lkostrowski/replace-moment-native branch March 11, 2026 14:04

Copilot started reviewing on behalf of lkostrowski March 11, 2026 14:04 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

		// Reset time, so timezone will not flip the day
		const thresholdDate = new Date(`${thresholdDateString}T00:00:00`);

-  // Reset time, so timezone will not flip the day
-  const thresholdDate = new Date(`${thresholdDateString}T00:00:00`);
+  // Reset time, so timezone will not flip the day for date-only values.
+  // If the env var already includes a time component (e.g. full ISO datetime),
+  // parse it as-is to avoid creating an invalid date string.
+  const thresholdDate = thresholdDateString.includes("T")
+    ? new Date(thresholdDateString)
+    : new Date(`${thresholdDateString}T00:00:00`);

	// todo do not accept optional value, check for existence higher
	// TODO: do not accept optional value; check for existence higher

Conversation

lkostrowski commented Mar 9, 2026

Scope of the change

Uh oh!

changeset-bot bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Mar 9, 2026 •

edited

Loading

codecov bot commented Mar 9, 2026 •

edited

Loading